Rails 4.2 Support

[ScotterC]

It appears that Rails 4.2.0.beta2 breaks core FriendlyId functionality.

class Category < ActiveRecord::Base
  extend FriendlyId
  friendly_id :title, use: [:slugged, :finders]
end
#  id             :integer          not null, primary key
#  title          :string(255)
#  slug           :string(255)      indexed

title = "foo bar"
Category.create(title: title)
Category.find title
# => ActiveRecord::RecordNotFound Exception: Couldn't find Category with 'id'=foo bar

[norman]

Ugh, this is why I've wanted to get rid of :finders for so long. Each major release breaks this. 😠

Does Category.friendly.find(title) still work?

[ScotterC]

Yup. friendly still works so we got that going for us.

[petergoldstein]

There are two failing specs under Rails 4.2.0.beta1.

1. HistoryTestWithFriendlyFinders#test_should_be_findable_by_old_slugs - Just started looking at this one.
2. ScopedTest#test_should_detect_scope_column_from_belongs_to_relation - I've got a fix for this one. Rails 4.2 switched to using String keys for the reflections hash. So the FriendlyId method just needs to check the symbol key first, and fall back to a String key.

I'm going to see if I can suss out the first issue today and submit a PR

[norman]

@petergoldstein did you ever adance on this? The only one still failing is test_should_be_findable_by_old_slugs; I'm looking at it right now, but if you already have a fix let me know and I'll move on to something else.

[norman]

I've been looking at this since late yesterday and have isolated the spec failure to some behavior I can't explain and suspect is a bug in Rails.

When the model's table has a type column, and the model uses the :finders module, then Model.find will use the friendly find method. When it does not, then it uses the default find method from the model and fails. However, exists? will work as expected.

You can reproduce this by editing schema.rb to add this line

add_column :restaurants, :type, :string

and then running

BUNDLE_GEMFILE=gemfiles/Gemfile.rails-4.2.rb bundle exec ruby -Itest test/history_test.rb -n HistoryTestWithFriendlyFinders#test_should_be_findable_by_old_slugs

which will pass. If you comment out the line in the schema, then it will fail.