Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set slug to nil on dup #483

Merged
merged 1 commit into from
Nov 13, 2013
Merged

Set slug to nil on dup #483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/friendly_id/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,5 +246,10 @@ def to_param
friendly_id.presence.to_param || super
end
end

# Clears slug on duplicate records when calling `dup`.
def dup
super.tap { |duplicate| duplicate.slug = nil }
end
end
end
7 changes: 7 additions & 0 deletions test/shared.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,13 @@ module Slugged
end
end

test "should set the slug to nil on dup" do
with_instance_of model_class do |record|
record2 = record.dup
assert_nil record2.slug
end
end

test "when validations block save, to_param should return friendly_id rather than nil" do
my_model_class = Class.new(model_class)
self.class.const_set("Foo", my_model_class)
Expand Down