Make UUID regex match only exact UUIDs (currently, it'll match strings with UUIDs anywhere in the string) #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with UUIDs anywhere in the string)
|
Thanks for this - good catch. Could you possibly add a test for this so that we are sure to avoid future regressions? |
|
Done! I changed the tests I put together last time to actually think they're using a UUID (rather than a string). |
| @@ -47,7 +47,7 @@ def potential_primary_key?(id) | |||
| when :integer | |||
| Integer(id, 10) rescue false | |||
| when :uuid | |||
| id.match /[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}/ | |||
| id.match /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/ | |||
There was a problem hiding this comment.
Can this use the following regular expression instead:
id.match /\A[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}\z/In Ruby, ^ will only match the start of a line and $ will only match the end of a line whereas \A will match the absolute start of input and \z will match the absolute end of input. This projects from particular injection attacks but in general, in my opinion, is just more complete.
norman
added a commit
that referenced
this pull request
May 29, 2014
Make UUID regex match only exact UUIDs (currently, it'll match strings with UUIDs anywhere in the string)
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the original fix to handle UUIDs sometime last year, and just now realized this issue. The UUID regex needs to match exact UUIDs. Right now, the UUID regex passes when there's a UUID at the end of a slug, which is what occurs for duplicates. This can result in errors like
when it should instead result in a RecordNotFound error.