New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign to configured slug column, not "slug", when validation fails #779

Merged

parndt merged 1 commit into norman:master from cgunther:fix-issue-765

Jan 25, 2017

Contributor

cgunther commented Dec 2, 2016

1f8af74 mistakenly assigns to the literal slug method, rather than the configured slug_column. As a result, models using a custom slug_column get an error raised when validations fail that slug= is an undefined method.

Fixes #765.

cgunther mentioned this pull request

undefined method `slug=' for Model #765

Closed

coveralls commented Dec 2, 2016 •

edited

Loading

Coverage remained the same at 96.734% when pulling 8cf0e7e on cgunther:fix-issue-765 into 920af01 on norman:master.

5 similar comments

coveralls commented Dec 2, 2016 •

edited

Loading

Coverage remained the same at 96.734% when pulling 8cf0e7e on cgunther:fix-issue-765 into 920af01 on norman:master.

coveralls commented Dec 2, 2016

Coverage remained the same at 96.734% when pulling 8cf0e7e on cgunther:fix-issue-765 into 920af01 on norman:master.

coveralls commented Dec 2, 2016

Coverage remained the same at 96.734% when pulling 8cf0e7e on cgunther:fix-issue-765 into 920af01 on norman:master.

coveralls commented Dec 2, 2016

Coverage remained the same at 96.734% when pulling 8cf0e7e on cgunther:fix-issue-765 into 920af01 on norman:master.

coveralls commented Dec 2, 2016

Coverage remained the same at 96.734% when pulling 8cf0e7e on cgunther:fix-issue-765 into 920af01 on norman:master.


          Assign to configured slug column, not "slug", when validation fails

cb4ddf1

1f8af74 mistakenly assigns to the literal `slug` method, rather than
the configured `slug_column`. As a result, models using a custom
`slug_column` get an error raised when validations fail that `slug=` is
an undefined method.

Fixes norman#765.

cgunther force-pushed the fix-issue-765 branch from 8cf0e7e to cb4ddf1 Compare

December 5, 2016 18:17

coveralls commented Dec 5, 2016 •

edited

Loading

Coverage remained the same at 96.734% when pulling cb4ddf1 on cgunther:fix-issue-765 into 920af01 on norman:master.

2 similar comments

coveralls commented Dec 5, 2016

Coverage remained the same at 96.734% when pulling cb4ddf1 on cgunther:fix-issue-765 into 920af01 on norman:master.

coveralls commented Dec 5, 2016

Coverage remained the same at 96.734% when pulling cb4ddf1 on cgunther:fix-issue-765 into 920af01 on norman:master.

ezekg mentioned this pull request

Update friendly_id to v5.2.0 spree/spree#7758

Closed

marshall-lee mentioned this pull request

Use friendly_id_config.slug_column in unset_slug_if_invalid. #783

Closed

Contributor

marshall-lee commented Dec 22, 2016

@parndt @kimrgrey @norman

Please please merge this one and release it in "5.2.1"! :)

We really need this unset_slug_if_invalid callback and other changes introduced in "5.2.0" but our tests fail on one of the models with non-standard slug field.

ezekg commented Dec 22, 2016 •

edited

Loading

Spree Commerce is also waiting on this patch: spree/spree#7758. Appreciate all the work that you put into this lib, everyone. 👍

ezekg commented Jan 19, 2017

Is there anyway we could get this merged so that we can update friendly_id for Spree 3.3?

parndt merged commit d29ec3d into norman:master

Collaborator

parndt commented Jan 25, 2017

Thanks @cgunther ❤️

Contributor

vfonic commented Apr 7, 2017 •

edited

Loading

+1 thanks for all the work! /cc @parndt
Can you please release 5.2.1?

Collaborator

parndt commented Apr 9, 2017

@vfonic done 😄 thanks for the reminder.

Contributor

vfonic commented Apr 9, 2017

Thanks! 🍾 🎉 😄

Contributor

marshall-lee commented Apr 27, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet