Fix deprecation warnings on Rails 5.2 (and some 5.1 fixes) #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We allow activerecord >= 4.0, so we should do the same for railties (which is just a dev dependency)
Rails 5.0+ wants us to specify the version of Rails we intend the migration for. This causes a deprecation warning on rails 5.0 and 5.1, and errors on rails 5.2
Fixes warnings like: DEPRECATION WARNING: Dangerous query method (method whose arguments are used as raw SQL) called with non-attribute argument(s): "\"friendly_id_slugs\".id DESC". Non-attribute arguments will be disallowed in Rails 6.0. This method should not be called with user-provided values, such as request parameters or model attributes. Known-safe values can be passed by wrapping them in Arel.sql().
|
time for a release to work on 5.1/5.2, or not yet? |
|
Have a few other things I'd like to tidy up first, but soon. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes migration warnings which were introduced in Rails 5.0 and became errors in Rails 5.1.
This also fixes deprecation warnings introduced in Rails 5.2
I believe the build error here is the same that is on master