Fix build and test against Rails 5.1 and 5.2 #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The referenced activerecord-jdbcmysql-adapter branch no longer exists
These older versions of ActiveRecord require pg ~> 0.15, and won't accept the newest pg version 1.0.0
saiqulhaq
reviewed
Apr 21, 2018
|
I believe this is ready to go! A quick summary of changes:
@parndt could I trouble you for a review and hopefully a new gem release? Thanks so much 🙇♂️ |
The jdbc adapters arent working with the latest patch releases of Rails. We'd like to test these if they could work, so I've added them to allowed_failures instead of fully excluding them.
This fixes build errors under Rails 4.0 and 4.1. We always want to perform this callback, even if ActiveRecord is being used standalone without the rest of Rails.
|
@jhawthorn you could trouble me indeed as it seems you've gone to great trouble to achieve this great work! Thank you, John! |
parndt
approved these changes
Apr 24, 2018
This was referenced Apr 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some small issues with the build and adds gemfiles to test against Rails 5.1 and 5.2.
It would be wonderful if we could get a new gem release to support Rails 5.2 🙏 💎
EDIT:
I'm still seeing some errors on Rails 4.0 and 4.1. A git bisect suggests this may be introduced by 4bd4300. I'm investigating further 🔍 . (but maybe it is time to drop 4.0 and 4.1)
EDIT2: This is fixed by reverting 4bd4300. Not sure why.