Fix exists? to behave the same as find for numeric slugs #875
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a record is created with a slug that is an integer (123, for example),
Model.friendly.find("123")
finds the correct record with slug of "123", butModel.friendly.exists?("123")
returns false.Referencing the comment here:
.find()
is correctly finding the record by its slug "123". Code referenceHowever,
.exists?
does not behave in the same way. It immediately passes to super looking for a record with an id of 123 based on.friendly_id?
. Code referenceI've updated
.exists?
to take a similar approach to find in looking for a record with the slug first and only passing it to super if none is found.