Pass all 4 parameters (message, model_name, query_field and id) to ActiveRecord::RecordNotFound.new when raising the exception. #890
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my Rails App, I had written a common rescue for
ActiveRecord::RecordNotFound
inApplicationController
.When this exception is rescued, I form a common error message:
This worked fine when the model does not use
FriendlyId
.In order to make this work with models that use
FriendlyId
, I have passed all four parameters (message, model_name, query_field and id) to ActiveRecord::RecordNotFound.new when it is being raised in finder_methods.rb.