Fix/Slug Validation in unset_slug_if_invalid

[Ancez]

updated unset_slug_if_invalid to only validate errors for the slug field instead of all model fields.

closes #902

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[parndt]

@Ancez hi! Could you please pull in the latest changes from master into this PR?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[Ancez]

@Ancez hi! Could you please pull in the latest changes from master into this PR?

Will do later on today, sorry for the late response

[nedenwalker]

Hi there @Ancez and @parndt ! We encountered the same issue today in our rails app that this PR purports to fix. We were wondering about the state of it and whether there is something we can do to help?

[parndt]

@nedenwalker It needs rebasing against master because it's failing CI on its current HEAD.

Does the change fix your problem?

[nedenwalker]

@parndt I can confirm that the fix does eliminate the bug. When the form reloads with previous form values and error messages, the slug field is now also present.

[nedenwalker]

Wasn't sure on how to run teamcity? tests locally or rebase someone else's fork etc, so made my own fork, made the code change and submitted a new PR to get CI running in your system: #936

[nedenwalker]

Figured out local testing issue, was running bundle exec rails test, needed to instead do bundle exec rake test. I see lots of failures. Will need some time to process it all, since change was a one-liner, hopefully fix to tests is also a one liner.

[nedenwalker]

@parndt I see 5 test failures, all related to the code change. I cannot admit to understanding the coding enough, but in particular, I see one test that specifies the code should do what it used to do, ie wipe the slug when there is another field validation failure. This code change would alter that contract. https://github.com/norman/friendly_id/blob/master/test/slugged_test.rb#L95 Will leave it to you to determine if the functionality should change or not.

[Ancez]

yeah there are some tests to fix otherwise this fixes the issue of the slug being removed. If you want to you can fork this line and fix the specs for it. If not then I'll fix these specs tonight if that's alright, until then I recommend changing the base within your projects Gemfile for this gem to this PR

[khng]

Fixed the test and submitted a new PR here: #938.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.