use destroy_all rather than delete_all when creating historical… #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if users augment FriendlyId::Slug with callbacks, they should be invoked
parndt
reviewed
Nov 20, 2019
remove unintentional whitespace. Co-Authored-By: Philip Arndt <git@p.arndt.io>
parndt
approved these changes
Nov 20, 2019
|
Thank you @alexdean ! 👍 🥇 |
parndt
changed the title
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our application adds an
after_commitcallback toFriendlyId::Slug. The usage ofdelete_allrather thandestroy_allinFriendlyId::History::FinderMethods#create_slugmeans that this callback is not always invoked.This PR changes this
delete_allto adestroy_all, which will invoke callbacks for the deleted records. Performance impact should be minimal given that (at most) 1 record is loaded and then deleted.Additionally: I noticed that no tests failed when i removed the
delete_allcall entirely. I think the test I've added will guard against that.