Fix mysql jobs in CI build matrix #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbrictson
force-pushed
the
fix-mysql-ci-failures
branch
2 times, most recently
from
f9a9e71 to
e777f53
Compare
mattbrictson
force-pushed
the
fix-mysql-ci-failures
branch
from
e777f53 to
cef6fd0
Compare
mattbrictson
commented
Apr 12, 2020
| @@ -23,7 +23,7 @@ jobs: | |||
| ruby-version: ${{ matrix.ruby }} | |||
| version: ${{ matrix.ruby }} | |||
| - uses: actions/checkout@v1 | |||
| - run: sudo apt-get update && sudo apt-get install libpq-dev postgresql-client libmysqlclient-dev libsqlite3-dev -y | |||
| - run: sudo apt-get update && sudo apt-get install libpq-dev postgresql-client libmysqlclient-dev mysql-client libsqlite3-dev -y | |||
There was a problem hiding this comment.
mysql-client is needed because rake db:create uses the mysql CLI.
| @@ -71,7 +71,7 @@ namespace :db do | |||
| driver = FriendlyId::Test::Database.driver | |||
| config = FriendlyId::Test::Database.config[driver] | |||
| commands = { | |||
| "mysql" => "mysql -u #{config['username']} --password=#{config['password']} -e 'create database #{config["database"]};' >/dev/null", | |||
| "mysql" => "mysql -h #{config['host']} -P #{config['port']} -u #{config['username']} --password=#{config['password']} -e 'create database #{config["database"]};' >/dev/null", | |||
There was a problem hiding this comment.
I had to add host and port, otherwise mysql would try (and fail) to connect to /var/lib/mysql/mysql.sock.
|
Amazing thank you so much!! |
This was referenced Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mysql jobs are failing in CI. It seems this is because there is no mysql service running. Fix by adding a mysql service to the CI config.