SimpleI18n: Handle regional locales #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It defines how to use slug columns for locales with region subtags.
|
It makes sense to do this. If we release this as 6.0.0 then it would be OK even if it's a breaking change. |
parndt
approved these changes
Jan 31, 2021
|
@parndt Thanks so much! 🙏 |
|
likewise @xymbol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It defines how to use slug columns for locales with region subtags.
This could result in a breaking change for people using column names like
title_pt-BR. Here I try to be explicit about and define how to use subtags, which we currently don't.