Add allow_nil: true option to the finder
#995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemsak
changed the title
parndt
reviewed
Jul 14, 2022
parndt
changed the title
allow_nil: true option to the finder
parndt
reviewed
Jul 14, 2022
Co-authored-by: Philip Arndt <git@p.arndt.io>
parndt
approved these changes
Jul 14, 2022
|
Thanks, Joe! 🎉 |
parndt
added a commit
that referenced
this pull request
Jul 21, 2022
Turns out, the documentation I added in #995 wasn't 100% accurate. I had to add tests for such examples and improve the internal code to support the option. This should now provide the fully expected behavior. Co-authored-by: Philip Arndt <git@p.arndt.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional
allow_nil: trueoption to the finderFrom discussion in #937 the idea is to add functionality that behaves like Rails'
find_bywhich returnsnilwhen a record is not found.This is useful in conditions where the developer is allowing the primary key ID and the friendly slug ID but is not sure if the record will actually be found, and wants a nil instead of a raised exception.
Usage