migrate to github actions #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmfigol
approved these changes
Feb 15, 2020
There was a problem hiding this comment.
Great work!
I have mostly comments:
- currently the build is triggered twice on push to a branch involved in PR. I haven't found an easy way to change it so it covers all our needs and probably complexity is not justified, especially considering it's GH CPU cycles, so whatever :D
- actually I like that we don't run nornir in docker and just use venvs, I have nothing against it.
- I have some concerns about caching the whole venv, but I think we can wait a see if we hit any issues. Alternative would be caching pip wheels.
- I see that pytest skip was removed. I probably still want to have a way to skip tests which depend on services, but it could be a separate PR if needed. Also we will probably not have these services tests anyway once plugins are removed from the core.
It's LGTM, though I'd suggest not merging this until @ktbyers has a chance to go through it too so he is somewhat familiar with the change as well.
|
This is fine with me. |
Yes, that's by design and that's correct. The jobs may contain different code if your branch is missing some commit from base. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adios travis, hola github actions.
In addition I removed the dependency of running the tests inside containers. I am not a fan of that change but it simplifies the migration. I might look into reverting this in the future but for now this is cleaner and easier.