Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NBInventory - adds device name if no primary IP #534

Merged
merged 3 commits into from
Jul 7, 2020
Merged

NBInventory - adds device name if no primary IP #534

merged 3 commits into from
Jul 7, 2020

Conversation

jvanderaa
Copy link

@jvanderaa jvanderaa commented Apr 30, 2020

  • Updates NetBox name in docs
  • Adds else statement to use device name if there is not a primary IP address

Fixes the NetBox plugin around issue 289, but not the rest of the plugins

@jvanderaa jvanderaa changed the title Fixes #289 - adds device name if no primary IP NBInventory - adds device name if no primary IP Apr 30, 2020
@dbarrosop
Copy link
Contributor

@wvandeun @clay584 would you mind looking at this PR and making sure it's also applied to your repo?

@wvandeun
Copy link
Contributor

LGTM
@jvanderaa plugins are going to be split from the main Nornir project from version 3. The NetBox inventory plugin will move to its own repository.
Can you please raise a PR on that repo with the same changes?

On top of that we are also looking to deprecate NBInventory for NetBoxInventory2, which is available in the new repo, would be good if you incorporate the changes there as well.

https://github.com/wvandeun/nornir_netbox

@jvanderaa
Copy link
Author

This was applied in the repo for the next iterations. Good to close or merge this PR @dbarrosop ?

@dbarrosop
Copy link
Contributor

Thanks for the heads up, I will merge here as well as I want to release a 2.4.x release right before nornir 3.x :)

@dbarrosop dbarrosop merged commit 08f7419 into nornir-automation:develop Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants