Add ability to add groups to Inventory Element & Hosts at runtime. #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge Feature/dynamic group to allow assignment of InventoryElement to Group at Run Time
kpeterson-sf
commented
Sep 22, 2020
dbarrosop
reviewed
Oct 4, 2020
dbarrosop
reviewed
Oct 4, 2020
dbarrosop
reviewed
Oct 4, 2020
dbarrosop
reviewed
Oct 4, 2020
dbarrosop
reviewed
Oct 4, 2020
|
Excellent PR, a few things have change in nornir3 making some of the comments in the issue obsolete (sorry about that) but I think the |
…r into feature/dynamic_group
Feature/dynamic group
dbarrosop
reviewed
Dec 21, 2020
| :param group: Group object to remove | ||
| :return: None | ||
| """ | ||
| super().remove(group) |
There was a problem hiding this comment.
I think this means the method isn't really necessary as we get the same behaviour without it, right? Or am I missing something?
There was a problem hiding this comment.
Yeah don't see any reason it needs to stay there.
|
apologies this is taking so long... |
|
Closed in favor of #624 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update inventory to allow for the addition of groups to an Inventory Element at run time.
Added two methods to the InventoryElement: add() & remove()
Added two methods to Host: add_to_group() and remove_from_group()
Closes #430