Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix InitNornir example in docs/configuration/index.rst #598

Merged
merged 3 commits into from
Oct 4, 2020
Merged

Fix InitNornir example in docs/configuration/index.rst #598

merged 3 commits into from
Oct 4, 2020

Conversation

ubaumann
Copy link
Contributor

Fix "Broken example for InitNornir" from #594

@ktbyers
Copy link
Collaborator

ktbyers commented Oct 2, 2020

Everything else looks good except for the aforementioned runners to runner change.

@ktbyers
Copy link
Collaborator

ktbyers commented Oct 3, 2020

FYI, the testing failures are due to other issues which I fixed in a separate PR.

@dbarrosop
Copy link
Contributor

dbarrosop commented Oct 4, 2020 •
edited
Loading

Awesome! I rebased and now it’s all green. Thanks for the PR and thanks @ktbyers for fixing that awful issue in our dependencies...

@dbarrosop dbarrosop merged commit ba4bf75 into nornir-automation:develop Oct 4, 2020
@dbarrosop dbarrosop mentioned this pull request Oct 4, 2020
Closed
@ubaumann
Copy link
Contributor Author

ubaumann commented Oct 4, 2020

Thanks for rebase it and thanks for all your time

@ubaumann ubaumann deleted the fix_docs_configuration_init branch October 4, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktbyers ktbyers ktbyers left review comments

@dbarrosop dbarrosop dbarrosop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ubaumann @ktbyers @dbarrosop