Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #621
When resolving data nornir would start climbing up the tree until reach the defaults, however, the desired behaviour was to climb the tree and then back down for the next group before checking reaching the defaults, which should be checked only as a last resort.
For instance, with the tree below:
Before the behaviour was
host -> g1 -> g11 -> defaults
and now it ishost -> g1 -> g11 -> g12 -> g2 -> defaults
In addition, this introduces two new methods:
extended_data
, which returns the data of a given host or group, including its inherited dataextended_groups
, which includes a list of groups the host or group belongs to including its inherited groupsFinally, the
dict
method was resolving the attributes of the hosts and groups, which wasn't supposed to happen, it's been fixed