-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nornir Filtering Deep Dive How To #674
Conversation
Jupyter test passing on my local machine using python3.8:
|
Tests are now passing. There were issues with my yaml files. Now ready for review. |
Looks really good, just a couple of comments:
|
On a second look, it is not as long, there is a lot of output and code examples and looks long but it isn't. |
Great, glad you agree. A lot of it is quite verbose and a lot of just printing outputs. I thought it would be better to give more detail and hopefully it's received well. |
For sure @dbarrosop, is this where you need me to create a markdown post into (obviously in a new 2021 folder)?: https://github.com/nornir-automation/nornir.tech.src/tree/master/content/posts/ I can write something up, and we can announce it from there. I feel like this is a good way of communicating from the official project. |
I think it's best to merge this code first and make sure all that works. But I've done all the work for the blog post and the PR is ready for the website here: |
Sounds good to me, merging! |
Hi nornir maintainers,
As discussed with @dbarrosop in #643, I've created a filtering deep dive how to, to add to the official docs.
It's pretty detailed, but hopefully you are happy with it and it makes sense.