-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ruamel dependency #694
Conversation
This is failing due to issue #695 not because of any changes made here. |
pyproject.toml
Outdated
@@ -25,7 +25,7 @@ classifiers = [ | |||
|
|||
[tool.poetry.dependencies] | |||
python = "^3.6" | |||
"ruamel.yaml" = "^0.16" | |||
"ruamel.yaml" = ">= 0.16, <0.18" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why <0.18
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not want to be over permissive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me elaborate, I did not want to be so permissive not knowing your initial intention
@itdependsnetworks Can you rebase and update your poetry.lock file (to get David's mypy fix). Also we should just do:
That should allow 0.16 and greater, but disallow 1.x.x. Alternatively we could just do >=0.16 |
I went with |
Thanks! |
No description provided.