Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ruamel dependency #694

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Conversation

itdependsnetworks
Copy link
Contributor

No description provided.

@itdependsnetworks
Copy link
Contributor Author

This is failing due to issue #695 not because of any changes made here.

pyproject.toml Outdated
@@ -25,7 +25,7 @@ classifiers = [

[tool.poetry.dependencies]
python = "^3.6"
"ruamel.yaml" = "^0.16"
"ruamel.yaml" = ">= 0.16, <0.18"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why <0.18?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not want to be over permissive

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me elaborate, I did not want to be so permissive not knowing your initial intention

@dbarrosop dbarrosop mentioned this pull request Jun 20, 2021
@ktbyers
Copy link
Collaborator

ktbyers commented Jun 20, 2021

@itdependsnetworks Can you rebase and update your poetry.lock file (to get David's mypy fix).

Also we should just do:

"ruamel.yaml" = "0.16.*"

That should allow 0.16 and greater, but disallow 1.x.x.

Alternatively we could just do >=0.16

@itdependsnetworks
Copy link
Contributor Author

I went with Alternatively we could just do >=0.16, since semantic versioning technically treats every "minor" version as potentially non-backwards compatible, and poetry respects that.

@dbarrosop
Copy link
Contributor

Thanks!

@dbarrosop dbarrosop merged commit 53a721f into nornir-automation:develop Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants