Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pylama breakage (pep8 reference no longer works) #836

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

ktbyers
Copy link
Collaborator

@ktbyers ktbyers commented Feb 17, 2023

It came to my attention on both the NAPALM and Netmiko repositories that pylama . no longer worked (for calling the linter).

Basically 'pycodestyle (pep8)' was no longer executed and it would just silently pass (even when you had linting issues). This update should fix this.

@ktbyers
Copy link
Collaborator Author

ktbyers commented Feb 17, 2023

The W503 linting exclusion was causing linting issues (where what black would correct to would actually fail the linter):

https://stackoverflow.com/questions/57074300/what-is-the-recommended-way-to-break-a-long-if-statement-w504-line-break-after?rq=1

It looked like pycodestyle would always fail regardless of the form I used with either a W503 or a W504 error...so I just chose the one that black used (and disabled the other one).

@ktbyers
Copy link
Collaborator Author

ktbyers commented Feb 17, 2023

@dbarrosop Can you disable this in GH settings (at least until someone fixes its failures):

CodeQL Expected — Waiting for status to be reported

I don't have access to settings for the Nornir repository (or I would disable it).

Thanks.

@dbarrosop
Copy link
Contributor

dbarrosop commented Feb 17, 2023

Can you disable this in GH settings (at least until someone fixes its failures):

Done.

I don't have access to settings for the Nornir repository (or I would disable it).

Made you owner of the full org so you should have access to the whole thing now.

@ktbyers ktbyers merged commit da15cce into nornir-automation:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants