Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 3.4.0 #858

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Bump version to 3.4.0 #858

merged 1 commit into from
Sep 21, 2023

Conversation

ogenstad
Copy link
Collaborator

It was a while since the last release and at work we are creating a Nornir plugin for our product but due to how the dependencies were setup for mypy-extensions in Nornir 3.3.0 I'm running into an issue when trying to add the latest version of mypy:

❯ poetry add --group dev mypy=1.5.1

Updating dependencies
Resolving dependencies... (0.0s)

Because mypy (1.5.1) depends on mypy-extensions (>=1.0.0)
 and nornir (3.3.0) depends on mypy_extensions (>=0.4.1,<0.5.0), mypy (1.5.1) is incompatible with nornir (3.3.0).
And because no versions of nornir match >3.3.0,<4.0.0, mypy (1.5.1) is incompatible with nornir (>=3.3.0,<4.0.0).

This problem has already been fixed in the main branch, so it would be great if we could release a new version.

Also bumped the Python version in setup.cfg as 3.7 was dropped.

@dbarrosop
Copy link
Contributor

Agreed, a release is long overdue. Any concerns @ktbyers?

@ktbyers
Copy link
Collaborator

ktbyers commented Sep 20, 2023

Sounds good to me.

@dbarrosop dbarrosop merged commit 325c8ca into main Sep 21, 2023
26 checks passed
@dbarrosop dbarrosop deleted the ogenstad-bump-version branch September 21, 2023 06:39
@ktbyers
Copy link
Collaborator

ktbyers commented Sep 21, 2023

@dbarrosop Let me know if you want me to fix this automated release process:

https://github.com/nornir-automation/nornir/blob/main/.github/workflows/main.yaml#L99

I think I said I would...though I am not sure I want to :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants