adds tcp_ping plugin #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice! |
dbarrosop
approved these changes
Sep 22, 2021
|
Test seems to be failing though, looks like localhost:22 is open while you expected it to be closed (inventory sets the ip of the fake devices to localhost) |
|
Interesting.
Ideally we would be able to reproduce this test "locally"
as well. Which is not the case right now, the container and my machine don't
listen on 22/tcp.
I can setup openssh (or something else) to have a local listening socket
in the container easily.
But it raises another question, I'm also looking into porting over the
command and remote_command tasks. For the testing of the remote_command task we would
need to have an openssh server.
Not sure if it is possible to do that with github runners. Not sure if
we can properly authenticate to the openssh server running on the
runner. (I'm not aware of the username/password and I seem to be unable
to create a ~/.ssh/authorized_keys file).
The only option I see is to run all of the tests in a container on the
runner, and spin up additional containers for each host defined in the
"inventory" (potentiall using your stupid_ssh_server).
But maybe I'm missing something here...
|
|
Github actions supports docker-compose so we could potentially start a few linux containers with openssh and use them for testing. We used to do that actually: |
|
Yep. I'll take a shot at it.
David Barroso ***@***.***> writes:
… Github actions supports docker-compose so we could potentially start a few linux containers with openssh and use them for testing. We used to do that actually:
nornir-automation/nornir@45c30a7
|
wvandeun
force-pushed
the
feature_tcp_ping
branch
from
e82a951 to
3c2eb67
Compare
- adds start_dev_env and stop_dev_env makefile targets - adds docker-compose file - modifies jupyter makefile target to run on host instead of docker container - add docker-jupyter makefile target to run jupyter notebook server in docker container
wvandeun
force-pushed
the
feature_tcp_ping
branch
from
b8185f9 to
8d64225
Compare
wvandeun
force-pushed
the
feature_tcp_ping
branch
from
43a75ab to
d5ed058
Compare
|
This one should be good now. There's a few changes:
|
|
A thousand apologies, i have no clue how I missed this PR for so long... Rebasing and merging. Sorry again for missing this :( |
|
Awesome! No need to apologize :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds tcp_ping plugin
closes nornir-automation/nornir#520