Skip to content

Comments

feat: role id methods#16

Merged
ced777ric merged 3 commits intonorthwood-studios:devfrom
LumiFae:role-extensions
Feb 15, 2025
Merged

feat: role id methods#16
ced777ric merged 3 commits intonorthwood-studios:devfrom
LumiFae:role-extensions

Conversation

@LumiFae
Copy link
Member

@LumiFae LumiFae commented Feb 13, 2025

adds extension methods based off of RoleTypeId to get relevant info for specific role ids

x3rt
x3rt previously approved these changes Feb 13, 2025
Copy link
Contributor

@x3rt x3rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just missing documentation on the class

@x3rt x3rt dismissed their stale review February 13, 2025 20:47

I may have mis-clicked, and meant to request changed. I am tired

@LumiFae LumiFae requested a review from x3rt February 13, 2025 21:54
Copy link
Contributor

@x3rt x3rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution

@x3rt
Copy link
Contributor

x3rt commented Feb 14, 2025

@ced777ric

@ced777ric ced777ric merged commit e7f87d4 into northwood-studios:dev Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants