Cross-plugin dependency fix#9
Merged
ced777ric merged 1 commit intonorthwood-studios:devfrom Feb 12, 2025
Merged
Conversation
Moved plugin type checking & loading to a separate loop in PluginLoader::LoadPlugins. Extracted the plugin instantiating and registering loop to a separate method InstantiatePlugins.
ced777ric
requested changes
Feb 12, 2025
ced777ric
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-plugin dependency fix
This PR fixes an issue where plugins would not load if they referenced another plugin that was not yet loaded.
The problem:
Assume the following scenario:
The following plugins are to be loaded:
Both
PluginAandPluginCdepend onPluginB.PluginBhas no dependencies.PluginA's assembly is loaded.PluginA, but fails because the dependencyPluginBis not yet found.PluginB's assembly is loaded and initialized.PluginCis loaded and starts without any issues.Changes:
This way, a plugin can reference another that comes after it alphabetically and will still be initialized correctly.