-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README.md templating #3
Comments
Hi Scott! Yes, I have been wanting to allow for users to put some amount of custom content into the README for a while, but couldn't find the right abstraction for making that happen. I think this is a wonderful idea, especially if we maintain backwards compatibility by implementing the following rules:
I don't have time to do this work immediately, but would be happy to review a pull request, or get on it in the coming weeks. |
@norwoodj Maybe I can help? What have you looked into thus far? I know there is a tool called confd (https://github.com/kelseyhightower/confd) that I used previously. It was for a different purpose, but case in point, it did file templating, and is written in Go as well. |
I have a good idea of how it would be implemented, just lacking the time to do it at present. I made some updates to the project yesterday to at least make further extension easier, but I probably won't have the time to implement the templating functionality for a week or two. |
@sc250024 I've implemented this feature and updated the documentation to reflect the changed behaviour. Please let me know when you get a chance to test this out if there's anything confusing, or if things don't work the way you expect. Thanks for the suggestion! |
@norwoodj Thank you so much ! I tested out the README.md rendering with our CI pipeline, and it works great. Kudos for all the hard work :) |
Hello, Firstly, this is a great tool. Wanted to understand a couple of things if they are supported.
|
First off, let me say this is an awesome project! This saves so much time, so thank you for doing it!
I'm submitting a ...
Do you want to request a feature or report a bug?
This is a feature request to have the CLI read from a
README.md.tpl
. The idea is that the user can then write some custom text for their README.md file, while also keeping the nice autogenerated Helm name, description, and variables.It would be nice if the CLI could read from a file
README.md.tpl
, which is defined by the user, specified in a command line flag. That way, something like the following could be done:README.md.tpl
The
helm-docs
CLI would then populate thechart_name
,chart_description
, andchart_variables
configuration blocks from chart specifications. The custom text in the middle (or wherever the user chooses) will be kept, resulting in a more complete README.md file for Helm charts.The command might be
helm-docs --template README.me.tpl
, and the template file would follow the Golang specification.Currently, the README.md file is written from the
helm-docs
command reading only theChart.yaml
file.The text was updated successfully, but these errors were encountered: