Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Apple M1 / Multi-Arch Docker builds #95

Merged
merged 4 commits into from
May 18, 2021
Merged

Support Apple M1 / Multi-Arch Docker builds #95

merged 4 commits into from
May 18, 2021

Conversation

sc250024
Copy link
Contributor

@sc250024 sc250024 commented Apr 26, 2021

Description

Solves #94.

@sc250024 sc250024 marked this pull request as draft April 26, 2021 14:00
The Linux package archives are currently not consistent with the rest of the tarballs being generated
@sc250024 sc250024 changed the title ci(github): updating goreleaser for M1 builds ci: updates to support apple silicon / multi-arch docker builds Apr 26, 2021
@sc250024 sc250024 marked this pull request as ready for review April 26, 2021 14:27
@sc250024 sc250024 changed the title ci: updates to support apple silicon / multi-arch docker builds ci: support apple silicon / multi-arch docker builds Apr 26, 2021
@sc250024 sc250024 changed the title ci: support apple silicon / multi-arch docker builds Support Apple M1 / Multi-Arch Docker builds Apr 26, 2021
@sc250024 sc250024 marked this pull request as draft April 26, 2021 14:59
@sc250024 sc250024 marked this pull request as ready for review April 26, 2021 15:57
@sc250024
Copy link
Contributor Author

sc250024 commented Apr 26, 2021

@norwoodj If you have a way of testing the Docker image builds with your DockerHub creds, when pushing, you should now see multiple digests corresponding to the different architectures.

I created an example repo called test-multi-arch in my own GitHub / DockerHub, and it appears like so after pushing.

multi-arch-example.png

multi-arch-example

@norwoodj
Copy link
Owner

Hello @sc250024. Thanks for the contribution. I'll try to take a look and merge soon

@norwoodj norwoodj merged commit 023fece into norwoodj:master May 18, 2021
@sc250024 sc250024 deleted the chore-GoReleaserM1 branch May 18, 2021 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants