Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): fixed unexpected router key warning #453

Merged
merged 2 commits into from
Aug 18, 2018

Conversation

mhuggins
Copy link
Contributor

Description

Fixes a console warning that began after switching to connected-react-router.

Motivation and Context

console.error node_modules/redux/lib/utils/warning.js:14
  Unexpected key "router" found in preloadedState argument passed to createStore.
  Expected to find one of the known reducer keys instead: "spunky", "dialogs",
  "browser", "requests", "toasts". Unexpected keys will be ignored.

How Has This Been Tested?

yarn test

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

N/A

@mhuggins mhuggins added the PR: needs review Pull request label Aug 18, 2018
@codecov
Copy link

codecov bot commented Aug 18, 2018

Codecov Report

Merging #453 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #453   +/-   ##
========================================
  Coverage    53.08%   53.08%           
========================================
  Files          153      153           
  Lines         1230     1230           
  Branches       161      161           
========================================
  Hits           653      653           
  Misses         486      486           
  Partials        91       91

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f76c545...50dfd18. Read the comment docs.

@DalderupMaurice DalderupMaurice merged commit 4e78d20 into develop Aug 18, 2018
@DalderupMaurice DalderupMaurice deleted the chore/router-tests branch August 18, 2018 09:24
@DalderupMaurice DalderupMaurice added PR: good to merge Reviewed and approved and removed PR: needs review Pull request labels Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants