chore(account): fixed TypeError for accounts with 3+ tokens #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #455 +/- ##
===========================================
+ Coverage 53.08% 53.13% +0.04%
===========================================
Files 153 153
Lines 1230 1229 -1
Branches 161 161
===========================================
Hits 653 653
+ Misses 486 485 -1
Partials 91 91
Continue to review full report at Codecov.
|
mhuggins
force-pushed
the
chore/type-error
branch
from
6993ec8 to
51b0e54
Compare
UglifyJsPlugin will inline single-use functions by default. This can result in an error stating `TypeError: Assignment to constant variable`. To work around this, the function is reused since there was an opportunity to do so anyway. mishoo/UglifyJS#2842 (comment)
mhuggins
force-pushed
the
chore/type-error
branch
from
51b0e54 to
eb9f57b
Compare
|
I don't have an account with 3+ tokens 😂😅 |
|
PM'd you an account to test this out on. |
DalderupMaurice
approved these changes
Aug 18, 2018
DalderupMaurice
added
PR: good to merge
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue with the distributable version (via
yarn dist) that caused the app crash when opening the Account screen.Motivation and Context
The app crashes when trying to render the breakdown chart with 3+ tokens. The error is:
This is caused by the uglify plugin inlining single-use functions, as discovered here: mishoo/UglifyJS#2842 (comment)
How Has This Been Tested?
yarn distto create a distributable version of the app.Types of changes
Checklist
Documentation
Closing issues
N/A