net: remove redundant connecting assignment

PR-URL: nodejs/node#43710 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
noslate-project · Oct 10, 2022 · bc045e1 · bc045e1
1 parent b7654bb
commit bc045e1
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/lib/net.js b/lib/net.js
@@ -1239,7 +1239,6 @@ function afterConnect(status, handle, req, readable, writable) {
       stopPerf(self, kPerfHooksNetConnectContext);
     }
   } else {
-    self.connecting = false;
     let details;
     if (req.localAddress && req.localPort) {
       details = req.localAddress + ':' + req.localPort;

diff --git a/test/sequential/test-net-connect-handle-econnrefused.js b/test/sequential/test-net-connect-handle-econnrefused.js
@@ -27,5 +27,6 @@ const assert = require('assert');
 const c = net.createConnection(common.PORT);
 c.on('connect', common.mustNotCall());
 c.on('error', common.mustCall((e) => {
+  assert.strictEqual(c.connecting, false);
   assert.strictEqual(e.code, 'ECONNREFUSED');
 }));