Skip to content

Commit

Permalink
test: mark flaky tests on smartos
Browse files Browse the repository at this point in the history
PR-URL: nodejs/node#43596
Refs: nodejs/node#43457
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
  • Loading branch information
F3n67u authored and guangwong committed Oct 10, 2022
1 parent 23ac14a commit ee25114
Show file tree
Hide file tree
Showing 6 changed files with 43 additions and 0 deletions.
10 changes: 10 additions & 0 deletions test/abort/abort.status
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,13 @@ prefix abort
[$system==ibmi]
# https://github.com/nodejs/node/issues/34410
test-addon-register-signal-handler: PASS,FLAKY

[$system==solaris] # Also applies to SmartOS
# https://github.com/nodejs/node/issues/43457
test-abort-fatal-error: PASS, FLAKY
test-abort-uncaught-exception: PASS, FLAKY
test-addon-register-signal-handler: PASS, FLAKY
test-process-abort-exitcode: PASS, FLAKY
test-signal-handler: PASS, FLAKY
test-worker-abort-uncaught-exception: PASS, FLAKY
test-zlib-invalid-internals-usage: PASS, FLAKY
2 changes: 2 additions & 0 deletions test/async-hooks/async-hooks.status
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ prefix async-hooks
[$arch==arm || $arch==arm64]

[$system==solaris] # Also applies to SmartOS
# https://github.com/nodejs/node/issues/43457
test-callback-error: PASS, FLAKY

[$system==freebsd]

Expand Down
5 changes: 5 additions & 0 deletions test/node-api/node-api.status
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,8 @@ prefix node-api
[true] # This section applies to all platforms

[$system==win32]

[$system==solaris] # Also applies to SmartOS
# https://github.com/nodejs/node/issues/43457
test_fatal/test_threads: PASS,FLAKY
test_fatal/test_threads_report: PASS,FLAKY
13 changes: 13 additions & 0 deletions test/parallel/parallel.status
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,19 @@ test-crypto-keygen: SKIP
[$system==solaris] # Also applies to SmartOS
# https://github.com/nodejs/node/issues/43446
test-net-connect-reset-until-connected: PASS, FLAKY
# https://github.com/nodejs/node/issues/43457
test-domain-no-error-handler-abort-on-uncaught-0: PASS, FLAKY
test-domain-no-error-handler-abort-on-uncaught-1: PASS,FLAKY
test-domain-no-error-handler-abort-on-uncaught-2: PASS,FLAKY
test-domain-no-error-handler-abort-on-uncaught-3: PASS,FLAKY
test-domain-no-error-handler-abort-on-uncaught-4: PASS,FLAKY
test-domain-no-error-handler-abort-on-uncaught-5: PASS, FLAKY
test-domain-no-error-handler-abort-on-uncaught-6: PASS, FLAKY
test-domain-no-error-handler-abort-on-uncaught-7: PASS, FLAKY
test-domain-no-error-handler-abort-on-uncaught-8: PASS, FLAKY
test-domain-no-error-handler-abort-on-uncaught-9: PASS, FLAKY
test-domain-throw-error-then-throw-from-uncaught-exception-handler: PASS, FLAKY
test-domain-with-abort-on-uncaught-exception: PASS, FLAKY

[$system==freebsd]
# https://github.com/nodejs/node/issues/31727
Expand Down
2 changes: 2 additions & 0 deletions test/pummel/pummel.status
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ test-crypto-timing-safe-equal-benchmarks: PASS,FLAKY
[$arch==arm || $arch==arm64]

[$system==solaris] # Also applies to SmartOS
# https://github.com/nodejs/node/issues/43457
test-heapsnapshot-near-heap-limit: PASS,FLAKY

[$system==freebsd]

Expand Down
11 changes: 11 additions & 0 deletions test/report/report.status
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
prefix report

# To mark a test as flaky, list the test name in the appropriate section
# below, without ".js", followed by ": PASS,FLAKY". Example:
# sample-test : PASS,FLAKY

[true] # This section applies to all platforms

[$system==solaris] # Also applies to SmartOS
# https://github.com/nodejs/node/issues/43457
test-report-fatal-error: PASS, FLAKY

0 comments on commit ee25114

Please sign in to comment.