Feature/add env event trigger plip signatures #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpirola
reviewed
Mar 30, 2022
| @@ -65,4 +65,4 @@ event_triggers: | |||
| interval_sec: 10 | |||
| num_retries: 0 | |||
| timeout_sec: 60 | |||
| webhook: http://n8n.enedina.bonde.org/webhook/plip-signatures-mautic | |||
| webhook_from_env: WEBHOOK_PLIP_SIGNATURES_MAUTIC_URL | |||
There was a problem hiding this comment.
@dieh seria bom adotar o padrão que estamos usando com os outros eventos.
lpirola
approved these changes
Mar 30, 2022
Codecov Report
@@ Coverage Diff @@
## main #37 +/- ##
=======================================
Coverage 63.28% 63.28%
=======================================
Files 41 41
Lines 640 640
Branches 92 92
=======================================
Hits 405 405
Misses 210 210
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
dieh
force-pushed
the
feature/add-env-event-trigger-plip-signatures
branch
from
a2c41f8 to
33d5f9a
Compare
dieh
commented
Mar 30, 2022
| @@ -65,4 +65,4 @@ event_triggers: | |||
| interval_sec: 10 | |||
| num_retries: 0 | |||
| timeout_sec: 60 | |||
| webhook_from_env: WEBHOOK_PLIP_SIGNATURES_MAUTIC_URL | |||
| webhook: "{{N8N_WEBHOOK_URL}}/plip-signatures-mautic" | |||
There was a problem hiding this comment.
@lpirola seria esse o formato?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.