Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integração com Certificados (REDIS) #38

Merged
merged 8 commits into from
Apr 1, 2022

Conversation

igr-santos
Copy link
Contributor

@igr-santos igr-santos commented Mar 29, 2022

  • Criar certificado apenas para dominios com DNS configurado (Ex.: *.comunidade.org.br)
  • Criar certificados para todos os subdominios do DNS configurado (Ex.: www.campanha1.comunidade.org.br)

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #38 (8cd17e7) into main (2028e29) will increase coverage by 2.93%.
The diff coverage is 97.61%.

❗ Current head 8cd17e7 differs from pull request most recent head 0a2ea42. Consider uploading reports for the commit 0a2ea42 to get more accurate results

@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   63.28%   66.21%   +2.93%     
==========================================
  Files          41       42       +1     
  Lines         640      663      +23     
  Branches       92       94       +2     
==========================================
+ Hits          405      439      +34     
+ Misses        210      198      -12     
- Partials       25       26       +1     
Flag Coverage Δ
unittests 66.21% <97.61%> (+2.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/domains-api/src/redis-db/certificates.ts 95.23% <95.23%> (ø)
...ins-api/src/controllers/certificates-controller.ts 79.31% <100.00%> (+22.94%) ⬆️
packages/domains-api/src/routes/events-route.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2028e29...0a2ea42. Read the comment docs.

@igr-santos igr-santos force-pushed the hotfix/certificate-generate branch from cfdceb7 to 8c239db Compare March 31, 2022 13:44
@igr-santos igr-santos changed the title Criar certificado apenas para dominios com DNS configurado Integração com Certificados (REDIS) Mar 31, 2022
@lpirola
Copy link
Contributor

lpirola commented Mar 31, 2022

Testando a integração completa encontramos um problema na interface, de resto tudo funcionou como deveria. Além de termos aumentado a cobertura de testes de maneira considerável.

@igr-santos
Copy link
Contributor Author

Testando a integração completa encontramos um problema na interface, de resto tudo funcionou como deveria. Além de termos aumentado a cobertura de testes de maneira considerável.

Problema na interface foi corrigido! E já está mergeado na main do bonde-clients

@igr-santos igr-santos merged commit b6841fd into main Apr 1, 2022
@igr-santos igr-santos self-assigned this Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants