-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIP-52/66 support #192
NIP-52/66 support #192
Conversation
9455064
to
bd252ab
Compare
Leaning towards extracting fetchers from Rationale:
Certain methods, such as the NIP-66 filter generation and a flexible fetcher would remain in this PR. The helper methods are what I am targeting to externalize to another library that implements |
Is this PR still active @dskvr ? There is one task left in the list above so I'm not sure if I should review or not? |
@erskingardner Never received any feedback on that item so couldn't finish it. I'm probably going to move most functionality into an NDK extension, because NDK does not natively support fetching of a full dataset and full coverage over NIP-66 would needlessly bloat NDK. Edit I can update this PR to reflect the updated, previously expressed scope of NIP-66 in NDK. Changing PR to draft. |
@erskingardner reduced the scope, still need feedback on
Didn't check coverage, but the important bits are tested. EDIT: Need to update the geotags in this PR, as NIP-115 has changed. Missed that. |
help needed
NDKEvent
insidekinds/nip66
but this is clearly not right.todo
content-tagger.ts
, revert before squashrelay-monitor.test.ts
relay-discovery.test.ts
relay-meta.test.ts
relay-monitor.test.ts
RelayMonitor.ts
? AnNDKRelayMonitor
class that implementsNDKUser
,NDKRelayLists
andNDKProfile
?RelayMonitor
fetchesRelayMonitor
fetchesGeoCodedEvents
(if needed)GeoCodedEvents.test.ts
depends on nostr-protocol/nips#230