-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIP-10 markers problem #812
Comments
Sorry, what is this solving? If the client is loading replies to root, filtering by |
The problem is getting just direct replies to root because every thread message has an e tag referencing the root. |
So if all messages mark root as |
Every reply would always have both |
So, how would you filter replies to root? Maybe you are saying that we must use |
Hmm yeah just this addition to |
Do you think requesting just the addition of |
I don't know what the other things are doing, but adding an |
Granted, you will miss a lot of reply events from non-compliant clients. |
Yes, but if most popular clients adheres and this was written in NIP-10, things would get better with time. |
Yeah, we can write a new tag. |
Marks are evil, there should be no more than 3 arguments to tags (type, value, data). So I think this is a very good suggestion in the abstract, I just don't know if adoption will ever be complete enough to rely on it. But I'll add it to coracle as well if this gets sufficient buy-in. |
Thanks for considering @staab. Please add the @mikedilger what about gossip client, can you adhere? |
How about focusing on improving the query syntax instead of doing this workaround? It would be more correct and backwards compatible. Example:
Meaning: give me events whose |
@fr4nzap this would be great. Except that it will probably never happen xD You would be asking all relays to change and become more complex because of a single use case, when a simple |
I find And I know that it would be difficult. Still worthy of discussion on a more general purpose, longer term NIP proposal with feedback from relay operators. |
I can add this to gossip. I think having a tag you can filter on is an improvement to a marker you cannot, so I support that. (already on unstable branch) |
I want to nag about
e
tag markers. The markers convention is really bad for clients that want to lazily load replies instead of loading everything at once. Motivation is saving bandwidth.One way of fixing it
without using markers:edit: after @vitorpamplona comments, keeping everything as-is but also just adding an uppercase
E
tag referencing the event you are replying to (for both root replies or reply replies) would be enough. For example, clients could lazy load direct root replies with this:["REQ", "dkldsaj", { kinds: [1], #E: ["<root id>"], limit: 5 }]
-e
anda
reference the root event (just to keep compatibility with existing clients that load every thread message at once; we can keep the "root" marker so that existing clients don't change code)-E
andA
reference the reply-to event and will have the same value of the lowercase versions when user is replying to the root message (lazy loading clients can use these tags)- mentions use NIP-21 nostr:nevent1... OR, if you really want a tag, use a new tag such asM
. Edit: Or better yet, use existingq
(quote) tag@jb55 @vitorpamplona @staab and other client authors please consider this when creating new messages. What do you think?
The text was updated successfully, but these errors were encountered: