-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIP-96: no transform #1262
NIP-96: no transform #1262
Conversation
LGTM! Ship it! |
ACK |
Simple and effective, it solves a need. I'm in |
I think it is still not clear if the server can send variants if I'll refer to my comment in the previous discussion regarding the
If it is critical for the user to make sure that the file has not changed, they can use |
I see no reason why not to serve variants under a separate and pre-communicated path. As long as the original file is the same, variants are irrelevant to this. |
I think variants can be handled in a similar manner to #1261 |
Co-authored-by: Santos <34815293+sant0s12@users.noreply.github.com>
ACK! |
What I mean by variant is anything that is not the original file. And I think that the expected correct behavior is not clear. Let me give an example: Is this the expected behavior? I'd say it makes more sense that the user must not make any assumptions about the image hash unless they specify In any case, if you all agree on the contrary, I think it would be worth it to specify that the server is expected to serve the same transformed file onward. |
Once the file is served under one hash, it will not be touched under the same URL (that is in the NIP) Behavior about the 301/302 is undefined, I agree. no_transform will essentially make file immutable. |
Where? I can't find it 😅 |
A continuation of #1236
@fishcakeday @nostrband @quentintaranpino