Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend NIP-52 to include e and p tags to calendar event RSVPs #1414

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

tyiu
Copy link
Contributor

@tyiu tyiu commented Aug 7, 2024

This PR attempts to address two use cases with calendar event RSVPs:

  1. I want a way to have my RSVP not hold true in perpetuity if I know that the calendar event I'm responding to has a chance of changing in a way that makes me not want to attend anymore.
  2. The author of the calendar event being responded to may want an easy way of pulling all responses to any event that they authored in one query.

@tyiu
Copy link
Contributor Author

tyiu commented Aug 7, 2024

@zmeyer44 @vicariousdrama @staab please review this NIP-52 calendar event RSVP amendment.

52.md Outdated Show resolved Hide resolved
@staab
Copy link
Member

staab commented Aug 7, 2024

I think we should limit this to adding optional e and a tags, since making a optional and e required isn't backwards-compatible. Adding language that clients SHOULD prefer the e tag if available basically gets us the pinning behavior you're looking for if clients start publishing e tags.

@vicariousdrama
Copy link
Contributor

I concur with @staab in that I'd prefer them to be optional.

@tyiu
Copy link
Contributor Author

tyiu commented Aug 8, 2024

@staab @vicariousdrama Updated.

@staab
Copy link
Member

staab commented Aug 9, 2024

LGTM, is this implemented anywhere?

@tyiu
Copy link
Contributor Author

tyiu commented Aug 9, 2024

LGTM, is this implemented anywhere?

No, I'll implement this now in Nostr SDK for Apple Platforms, which Comingle uses. Happy to hold off on merging until it's implemented.

@AsaiToshiya
Copy link
Collaborator

Won't making a optional break backward compatibility? I think the current implementations expect a to exist.

@staab
Copy link
Member

staab commented Aug 9, 2024

Ah yeah, good point, that's what I originally meant

@AsaiToshiya
Copy link
Collaborator

If clients prioritize e, there is no need to change a.

…quired 'a' tag and clarify how clients should or may interpret the optional 'e' tag
@tyiu
Copy link
Contributor Author

tyiu commented Aug 11, 2024

Thank you all for helping me iterate on this PR. I've pushed a commit to address your feedback.

@staab staab merged commit f8e108e into nostr-protocol:master Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants