Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "rename "parameterized replaceable event" to "addressable event"" #1437

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fernandolguevara
Copy link
Contributor

@fernandolguevara fernandolguevara commented Aug 20, 2024

Reverts #1418, as addressable concept means that something is specifically identified in a system, event id is applied as this for any event in nostr.
We should keep the old definition until we come up with a new one

@jb55
Copy link
Contributor

jb55 commented Aug 22, 2024

nack

@kehiy
Copy link
Contributor

kehiy commented Sep 11, 2024

I think we need to make a final decision here. at the moment there are places where we used both of these names. this concept is confusing enough itself.

@bezysoftware
Copy link
Contributor

I find the renaming to "addressable" to make no sense. Now the NIPs, including 01, are polluted with stuff like
a (maybe parameterized) replaceable event and "normal replaceable events"
Screenshot_20240928-143356
Bring back "replaceable" and "parametrized replaceable", stop this madness.

@vitorpamplona
Copy link
Collaborator

I don't mind either way, but "normal replaceable" is indeed weird.

Maybe it should be just replaceable then. Or just remove the world replaceable and make everything addressable (since "normal replaceables" are also addressable with d="")

@fiatjaf
Copy link
Member

fiatjaf commented Sep 28, 2024

The real madness is "parameterized replaceable", that is not a reasonable name. Come up with a better name, or a better set of names, instead, I'm all for that.

"Parameterized replaceable" is not descriptive, like what is the "parameter" that determines its replaceability, or what the hell all that means? "Addressable" matches naddr and "a" tags, that's it. Everything is just convention and getting used to.

But sure I'll clean the NIPs from these broken references, changes that should have gone in that other PR.

fiatjaf added a commit that referenced this pull request Sep 28, 2024
as noticed by @bezysoftware at #1437 (comment).

I don't know how so many of these instances were left from the original PR at following ca3c52e.
@bezysoftware
Copy link
Contributor

@fiatjaf still not a fan, but much better, thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants