-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "rename "parameterized replaceable event" to "addressable event"" #1437
base: master
Are you sure you want to change the base?
Revert "rename "parameterized replaceable event" to "addressable event"" #1437
Conversation
…t" (nostr-protocol#1418)" This reverts commit ca3c52e.
nack |
I think we need to make a final decision here. at the moment there are places where we used both of these names. this concept is confusing enough itself. |
I don't mind either way, but "normal replaceable" is indeed weird. Maybe it should be just |
The real madness is "parameterized replaceable", that is not a reasonable name. Come up with a better name, or a better set of names, instead, I'm all for that. "Parameterized replaceable" is not descriptive, like what is the "parameter" that determines its replaceability, or what the hell all that means? "Addressable" matches But sure I'll clean the NIPs from these broken references, changes that should have gone in that other PR. |
as noticed by @bezysoftware at #1437 (comment). I don't know how so many of these instances were left from the original PR at following ca3c52e.
@fiatjaf still not a fan, but much better, thx |
Reverts #1418, as addressable concept means that something is specifically identified in a system, event id is applied as this for any event in nostr.
We should keep the old definition until we come up with a new one