-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify quote reposts #1525
Clarify quote reposts #1525
Conversation
I agree that the q needs to be explained. Allowing an address on the same tag is a bit risky (we didn't do that with 'e' we created 'a' instead). I sure wish references just worked simply and worked everywhere (e.g. instead of the id being a hash it was a construction that could be replaced, and the hash was just a hash). But that is a pipedream, don't get distracted by my musing. |
Also, I'm not sure why we have quote reposts at all. I have no idea when my user intends to send a kind-6 repost or a kind-1 quote repost or a kind-1 mention. So gossip only generates kind-6 reposts and kind-1 mentions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I think we should make it explicit to say that a quote should also have the k tag in addition to the q tag.
IMO kind 1 quote reposts are the same as kind 1 mentions semantically. |
I think the "Quote repost" is unnecessary. Only the quotes should be there. Also NIP-10 should be deprecated. If you have multiple |
I think the definition of
|
Get rid of the |
I suggest merging into NIP-27. |
For this reason, I feel there is no need to support the addressable for now. |
Co-authored-by: Asai Toshiya <to.asai.60@gmail.com>
Ok, I've dropped the stuff about |
18.md
Outdated
|
||
`["q", <event-id>, <relay-url>, <pubkey>]` | ||
|
||
Quote reposts MUST include the [NIP-19](19.md) `nevent`, `note`, or `naddr` of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIP-21, in fact
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I know😅
How are we thinking about solving the address issue? I am one that needs to quote the address, not just the event id. It's weird to write a |
I was wrong. Gossip is using q tags, not e tags with mention markers. Also, +1 on this PR as it currently is. |
I agree. My vote would be to have a different version of the |
This change is fairly opinionated in terms of dictating best practices. I'm also not sure if address support is desired/implemented anywhere, so I'm happy to take that out if appropriate.
The diff is kind of hard to read because I moved the quote reposts section to the bottom of the NIP for better readability.