Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ETH address support #254

Closed
wants to merge 1 commit into from

Conversation

kernel1983
Copy link

I have implement with one client and one relay:

Client https://github.com/kernel1983/nostrweb/tree/eth_address
Relay https://github.com/kernel1983/pyrelay/tree/eth_address

Please kindly review the NIP and code.

@PierreRochard
Copy link

20,000+ "crypto" NIPs would make navigating this repo challenging

@fiatjaf
Copy link
Member

fiatjaf commented Feb 14, 2023

This is not backwards-compatible.

@fiatjaf fiatjaf closed this Feb 14, 2023
@fiatjaf
Copy link
Member

fiatjaf commented Feb 14, 2023

You can already use ETH addresses, by the way. If an ETH address is the hash of a secp256k1 pubkey you can just take the actual pubkey and use that as your Nostr key.

ETH-aware clients can then hash the Nostr key and check Infura for the existence of that address on Ethereum before showing a "send tip NFT" button or something like that.

@fiatjaf
Copy link
Member

fiatjaf commented Feb 14, 2023

You can also add your ETH address as a tag or property in your kind:0 metadata and just go from there. This will work for any "cryptos" or even Paypal addresses, if people want. There could be one single NIP accommodating this if there is interest from multiple shitcoiners.

@kernel1983
Copy link
Author

You can also add your ETH address as a tag or property in your kind:0 metadata and just go from there. This will work for any "cryptos" or even Paypal addresses, if people want. There could be one single NIP accommodating this if there is interest from multiple shitcoiners.

Yes, you can do it in a tag way, but your signature can not show you have the ownership of certain NFT or Token.
I believe more people will need this.

@fiatjaf
Copy link
Member

fiatjaf commented Feb 14, 2023

In that case we can agree on a canonical string to sign that includes the Nostr pubkey and attach a signature of that to the tag: tags: [["ethereum_address", "0x...", "signature"]]

@kernel1983
Copy link
Author

1 People can choose to show their 0x addr when they wish, but two popup to sign: nos2x + metamask
2 Maybe the double signed event are too early that the relay have already deleted

It would be easy to keep the 'pubkey' as it is fixed, we can do pubkey + eth_addr. However, it would be nice to also accept eth signature. It opens to a big world (NFT, Token, Metamask users).

@fiatjaf
Copy link
Member

fiatjaf commented Feb 14, 2023

We can't, because that would be a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants