Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add referencedPubkeys, referencedEventIds, and referencedEventCoordinates to NostrEvent #188

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

tyiu
Copy link
Contributor

@tyiu tyiu commented Oct 19, 2024

This PR deprecates the EventCoordinatesTagInterpreting protocol because:

  1. NIP-01 says that all event kinds can refer to addressable or replaceable events (i.e. reference event coordinates). I've added referencedEventCoordinates to NostrEvent.
  2. It's unclear what eventCoordinates means. Is it referring to the coordinates of the event object itself or events it's referencing? (it's the latter)

NIP-01 also says that all event kinds can refer to other events or users, so I've added referencedPubkeys and referencedEventIds to NostrEvent.

@tyiu tyiu merged commit 579ae07 into main Oct 19, 2024
5 checks passed
@tyiu tyiu deleted the tyiu/referenced-pubkeys-and-events branch October 19, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant