fix ron & json serialization of large floats #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for doing this, looks like a win all the way around |
knickish
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for JSON and RON, nanoserde serializes large floats as integers when possible, and during deserialization first reads them as integers and later converts to a float. This leads to a bug when handling large numbers. For example, 1e30 is serialized as "1000000000000000000000000000000", which attempts to be deserialized as a u64 and errors with a positive overflow.
This PR changes float serialization to use the debug trait rather than the display trait, resulting in the representation "1e30" which is deserialized directly to a float.