Rust nigthly & dependency fixes #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file tells cargo (and other tools, like vscode rust-analyzer plugin) to use the nightly toolchain by default. This is needed to correctly open the project in vscode with rust-analyzer. We should probably fix a nigthly version, but for now leave it as a generic `nightly`.
The feature(generic_associated_types) has been recently stabilized and does not need to be listed in the `#![feature(...)]` block. Also, move the `where` clauses on GAT impls to after the type assignment, taking advantage of a syntax change described here: rust-lang/rust#89122
bitvec-0.22.3 depends on yanked funty-1.2.0 and no longer builds. Update to bitvec-1.0.1 as this is the most recent version. Change a few API calls as they have been renamed. Move the framebuffer BitArray size to a constant so that it is not repeated.
Update clap to 4.0.26. Enable the `derive` feature to fix compilation. Change the derive attributes to work with newer version of clap. Drop apex_hardware::FareBuffer use.
Make `src/render/debug.rs` buildable.
It was called `crypto`, but the provider is called `coindesk` instead.
|
Hi! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the result of me trying to build
apex-tuxjust now.This PR fixes warnings about
feature(generic_associated_types)(which is no longer nightly exclusive), upgrades two dependencies and fixes the uses, and in general cleans up a few things.I have validated both
apex-tuxandapex-ctlwork on Linux on Apex 7. After addingmpris2integration tompd(using https://github.com/eonpatapon/mpDris2) and settingmpris2.preferred_playertompdinsettings.tomlI also managed to test the media player integration.