Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] When attempting to specify a path for the HDD file, open the file picker at the VM folder's location #4

Closed
eddmanx opened this issue Jan 9, 2025 · 6 comments
Labels
enhancement New feature or request

Comments

@eddmanx
Copy link

eddmanx commented Jan 9, 2025

Currently it opens at the manager exe location.

Something else I noticed; when creating the HDD in the VM folder, the absolute path is written in the cfg.
When using 86manager or 86box directly, for such cases only the file name is written, for example:

[Hard disks]
hdd_01_fn = Win98SE.vhd

Of course for any other outside location it should be absolute.

@eddmanx eddmanx added the enhancement New feature or request label Jan 9, 2025
@notBald
Copy link
Owner

notBald commented Jan 9, 2025

Good catch. I'll look into it.

notBald added a commit that referenced this issue Jan 9, 2025
@notBald
Copy link
Owner

notBald commented Jan 10, 2025

Fixed in Fixed in v1.1.1.

Thanks for your help.

@notBald notBald closed this as completed Jan 10, 2025
@eddmanx
Copy link
Author

eddmanx commented Jan 10, 2025

The main issue is fixed, but the second one still happens.

@notBald notBald reopened this Jan 10, 2025
@notBald
Copy link
Owner

notBald commented Jan 10, 2025

Strange. The problem was gone for a while, but now it's back for me too. I think I'll have to look at the 86Box source to see what I'm missing. Worst comes to worse, I'll fix it by editing the config file.

@notBald
Copy link
Owner

notBald commented Jan 10, 2025

One workaround is to not use the file browser when creating a vm disk, but write the name straight into the text box.

notBald added a commit that referenced this issue Jan 10, 2025
@notBald
Copy link
Owner

notBald commented Jan 10, 2025

Finally figured it out. Trimming off the path separator fixes the issue.

Thanks again.

@notBald notBald closed this as completed Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants