Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cards module to add double click function #1793

Merged

Conversation

wariofdz
Copy link
Collaborator

@wariofdz wariofdz commented Nov 6, 2024

Changed:

  • Modify BaseCard.tsx and his test to add new onDoubleClick function.
  • Modify DrawCard.tsx and his test to add new onDoubleClick function.
  • Modify ImageCard.tsx and his test to add new onDoubleClick function.
  • Modify ReverseCard.tsx and his test to add new onDoubleClick function.
  • Modify SkipCard.tsx and his test to add new onDoubleClick function.
  • Modify TextCard.tsx and his test to add new onDoubleClick function.
  • Modify WildCard.tsx and his test to add new onDoubleClick function.

@wariofdz wariofdz requested a review from notaphplover November 6, 2024 18:09
@wariofdz wariofdz self-assigned this Nov 6, 2024
…o feature/update-card-modules-onDoubleClick-event-param
Copy link
Owner

@notaphplover notaphplover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change the current approach

  • onDoubleClick must be a valid react mouse event handler.
  • Types must be fixed.

packages/frontend/web-ui/src/game/components/BaseCard.tsx Outdated Show resolved Hide resolved
packages/frontend/web-ui/src/game/components/DrawCard.tsx Outdated Show resolved Hide resolved
packages/frontend/web-ui/src/game/components/TextCard.tsx Outdated Show resolved Hide resolved
packages/frontend/web-ui/src/game/components/WildCard.tsx Outdated Show resolved Hide resolved
@wariofdz wariofdz requested a review from notaphplover November 6, 2024 20:10
@notaphplover notaphplover merged commit d751786 into master Nov 6, 2024
3 checks passed
@notaphplover notaphplover deleted the feature/update-card-modules-onDoubleClick-event-param branch November 6, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants