doc: update contributing guide #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Zha <yizha1@microsoft.com>
yizha1
requested review from
FeynmanZhou,
gokarnm,
justincormack,
NiazFK,
priteshbandi,
SteveLasker,
toddysm and
vaninrao10
as code owners
Signed-off-by: Yi Zha <yizha1@microsoft.com>
shizhMSFT
reviewed
Apr 26, 2023
Signed-off-by: Yi Zha <yizha1@microsoft.com>
|
I noticed that the instructions for committing and pushing changes don't include the signoff command, also known as DCO. I think it would be great to add this information to the instructions. Currently: git add <files_changed>
git commit -m <commit_message>
git push origin HEADExpected: git add <files_changed>
git commit -s -m <commit_message>
git push origin HEAD |
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Thanks @Sumitmaithani , Please check this section to see whether it solves your problem. |
|
@yizha1 👍 Looks great! |
FeynmanZhou
reviewed
May 15, 2023
FeynmanZhou
reviewed
May 15, 2023
FeynmanZhou
reviewed
May 15, 2023
toddysm
requested changes
May 16, 2023
Signed-off-by: Yi Zha <yizha1@microsoft.com>
FeynmanZhou
approved these changes
May 30, 2023
toddysm
requested changes
Nov 28, 2023
This was referenced Nov 28, 2023
|
Thanks for all the comments. I will resolve them before end of 12/22/2023. |
Signed-off-by: Yi Zha <yizha1@microsoft.com>
yizha1
dismissed stale reviews from priteshbandi and FeynmanZhou
via
bf7834d
yizha1
requested review from
toddysm,
priteshbandi,
FeynmanZhou and
shizhMSFT
priteshbandi
pushed a commit
to notaryproject/notation-go
that referenced
this pull request
Mar 18, 2024
This PR enables the `notation-go` repo to run stale action at 1:30 every day to label or close stale PRs and issues. See guideline https://github.com/marketplace/actions/close-stale-issues This is the definition for stale PRs or issues that we discussed during community call and to be updated in [contributing PR](notaryproject/.github#25). "A stale issue is one that remains inactive or without updates for a period of 60 days. A stale pull request (PR) is one that remains inactive or without updates for a period of 45 days. When an issue or PR becomes stale, it is labelled as `stale`. Normally maintainers will comment on stale issues or PRs to prompt participants to take action. If there is no activity for additional 30 days, this issue or PR will be closed. If an update/comment occur on stale issues or pull requests, the stale label will be removed, and the timer will restart" Signed-off-by: Yi Zha <yizha1@microsoft.com>
yizha1
added a commit
to notaryproject/notation
that referenced
this pull request
Mar 21, 2024
This PR enables the `notation` repo to run stale action at 1:30 every day to label or close stale PRs and issues. See guideline https://github.com/marketplace/actions/close-stale-issues This is the definition for stale PRs or issues that we discussed during community call and to be updated in [contributing PR](notaryproject/.github#25). "A stale issue is one that remains inactive or without updates for a period of 60 days. A stale pull request (PR) is one that remains inactive or without updates for a period of 45 days. When an issue or PR becomes stale, it is labelled as `stale`. Normally maintainers will comment on stale issues or PRs to prompt participants to take action. If there is no activity for additional 30 days, this issue or PR will be closed. If an update/comment occur on stale issues or pull requests, the stale label will be removed, and the timer will restart" Signed-off-by: Yi Zha <yizha1@microsoft.com> --------- Signed-off-by: Yi Zha <yizha1@microsoft.com>
yizha1
added a commit
to notaryproject/notation-core-go
that referenced
this pull request
Mar 21, 2024
This PR enables the `notation-core-go` repo to run stale action at 1:30 every day to label or close stale PRs and issues. See guideline https://github.com/marketplace/actions/close-stale-issues This is the definition for stale PRs or issues that we discussed during community call and to be updated in [contributing PR](notaryproject/.github#25). "A stale issue is one that remains inactive or without updates for a period of 60 days. A stale pull request (PR) is one that remains inactive or without updates for a period of 45 days. When an issue or PR becomes stale, it is labelled as `stale`. Normally maintainers will comment on stale issues or PRs to prompt participants to take action. If there is no activity for additional 30 days, this issue or PR will be closed. If an update/comment occur on stale issues or pull requests, the stale label will be removed, and the timer will restart" Signed-off-by: Yi Zha <yizha1@microsoft.com> --------- Signed-off-by: Yi Zha <yizha1@microsoft.com>
|
@priteshbandi @shizhMSFT @FeynmanZhou @toddysm Would you mind reviewing this PR again, which has been open quite a long time? Please be aware of some updates on the milestone naming according to Toddy's comment to bring more claritiy.
|
NiazFK
approved these changes
Apr 18, 2024
toddysm
approved these changes
Apr 19, 2024
JeyJeyGao
pushed a commit
to notaryproject/notation-go
that referenced
this pull request
May 29, 2024
This PR enables the `notation-go` repo to run stale action at 1:30 every day to label or close stale PRs and issues. See guideline https://github.com/marketplace/actions/close-stale-issues This is the definition for stale PRs or issues that we discussed during community call and to be updated in [contributing PR](notaryproject/.github#25). "A stale issue is one that remains inactive or without updates for a period of 60 days. A stale pull request (PR) is one that remains inactive or without updates for a period of 45 days. When an issue or PR becomes stale, it is labelled as `stale`. Normally maintainers will comment on stale issues or PRs to prompt participants to take action. If there is no activity for additional 30 days, this issue or PR will be closed. If an update/comment occur on stale issues or pull requests, the stale label will be removed, and the timer will restart" Signed-off-by: Yi Zha <yizha1@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #6
Signed-off-by: Yi Zha yizha1@microsoft.com