Consistent TUF Files #474
Consistent TUF Files #474
Conversation
endophage
force-pushed
the
consistent
branch
3 times, most recently
from
375aa3f to
fbfd710
Compare
endophage
force-pushed
the
consistent
branch
2 times, most recently
from
505f6ad to
ae37d01
Compare
| logger.Debug("200 GET snapshot") | ||
| w.Write(out) | ||
| return nil | ||
| } |
There was a problem hiding this comment.
it's great to see this red and the new simplification 👍
endophage
force-pushed
the
consistent
branch
2 times, most recently
from
7ebfc37 to
fa06bd6
Compare
| @@ -0,0 +1,89 @@ | |||
| package handlers | |||
There was a problem hiding this comment.
Not sure if logic.go is a good name for this file.
There was a problem hiding this comment.
Agreed. Just didn't want to get hung up on a filename which is irrelevant in the context of Go. Happy to change it to anything else but I haven't come up with a good name for it :-/
There was a problem hiding this comment.
maybe roles.go? I'm not sold on that name either but seems a little more descriptive
|
@cyli I think I've addressed your requests to add a second timestamp in the tests. I now create and add 2 timestamps and try to get the older one by checksum. |
|
Aside from the file renaming, if you want to do it, this LGTM! |
|
LGTM! |
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
…asier to manage filename system Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
Allows downloading TUF files by hash. Forward compatible for when we add Sha384/Sha512.