-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added notation CLI reference docs based on RC4 #183
Conversation
✅ Deploy Preview for notarydev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@zr-msft One question: I didn't see sub-commands for notation sign
and notation verify
. Do you plan to add them later?
@zr-msft Could you add a code block effect for each CLI command example like https://oras.land/cli_reference/? It would be much more convenient for users to copy. We will also add a Copy button to the code block soon. The layout will be much more comfortable if we put the example CLI command in the code block. |
@yizha1 There are reference docs for https://deploy-preview-183--notarydev.netlify.app/docs/cli-reference/notation_sign/ |
Signed-off-by: Zach Rhoads <zachary.rhoads@microsoft.com>
manually added code blocks to examples for now. Still need to research better automated generation of these changes, but thats out of scope for this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for a first version
fixes #163