-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created glossary.md and defined project brand related terms #326
Conversation
Signed-off-by: Roseline <roselynbassey23@gmail.com>
✅ Deploy Preview for notarydev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Roseline-Bassey . A few comments
Signed-off-by: Roseline <roselynbassey23@gmail.com>
Thanks, @yizha1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments left
Signed-off-by: Roseline <roselynbassey23@gmail.com>
Signed-off-by: Roseline <roselynbassey23@gmail.com>
Signed-off-by: Roseline <roselynbassey23@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Roseline <roselynbassey23@gmail.com>
Signed-off-by: Roseline <roselynbassey23@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Roseline-Bassey. Left some comments.
Signed-off-by: Roseline <roselynbassey23@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
LGTM |
@iamsamirzon Thanks for approving this PR, but it seems you need to remove "changed request", otherwise this PR cannot be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
… specification, and notation (#328) This PR adds a new section in faq.md to clarify the difference between Notary, Notary v2, Notation, TUF, and Notary Project. It fixes #323 I haven't included a link to the `glossary page` in the last line because PR #326 is still under review and has not been merged yet. I will update this PR with the link once #326 is merged. --------- Signed-off-by: Roseline <roselynbassey23@gmail.com> Co-authored-by: Yi Zha <yizha1@microsoft.com>
This PR includes the following:
This PR fixes #323
The difference between these terminologies would be documented in FAQ through another PR.