Remove opencontainer dependency for timestamping code #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
priteshbandi
commented
Jun 21, 2022
priteshbandi
commented
- timestamping shouldn't depend on opencontainers.
- Also, rephrased some of the error message for certificate chain validation.
added 2 commits
June 21, 2022 10:55
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
jondonas
approved these changes
Jun 23, 2022
gokarnm
requested changes
Jun 24, 2022
shizhMSFT
reviewed
Jun 27, 2022
Comment on lines
+3
to
+4
| // MalformedRequestError is used when timestamping request is malformed. | ||
| type MalformedRequestError struct { |
There was a problem hiding this comment.
It is better to name it ErrorMalformedRequest. It's a convention to put Error as a prefix.
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
shizhMSFT
reviewed
Jun 29, 2022
timestamp/request.go
Outdated
| return NewRequest(digest.FromBytes(content)) | ||
| } | ||
| // NewRequestWithContent creates a request based on the given data and hash algorithm. | ||
| func NewRequestWithContent(content []byte, alg crypto.Hash) (*Request, error) { |
There was a problem hiding this comment.
nit:
Suggested change
| func NewRequestWithContent(content []byte, alg crypto.Hash) (*Request, error) { | |
| func NewRequestFromContent(content []byte, alg crypto.Hash) (*Request, error) { |
timestamp/token.go
Outdated
| // Verify verifies the message against the timestamp token information. | ||
| func (tst *TSTInfo) Verify(message []byte) error { | ||
| // VerifyWithContent verifies the message against the timestamp token information. | ||
| func (tst *TSTInfo) VerifyWithContent(message []byte) error { |
There was a problem hiding this comment.
nit:
Suggested change
| func (tst *TSTInfo) VerifyWithContent(message []byte) error { | |
| func (tst *TSTInfo) VerifyContent(message []byte) error { |
timestamp/request.go
Outdated
Comment on lines
103
to
120
| func validate(digest []byte, alg crypto.Hash) error { | ||
| l := len(digest) | ||
| var validContent bool | ||
| switch alg { | ||
| case crypto.SHA256: | ||
| validContent = l == crypto.SHA256.Size() | ||
| case crypto.SHA384: | ||
| validContent = l == crypto.SHA384.Size() | ||
| case crypto.SHA512: | ||
| validContent = l == crypto.SHA512.Size() | ||
| default: | ||
| return MalformedRequestError{msg: fmt.Sprintf("unsupported hashing algorithm: %s", alg)} | ||
| } | ||
| if !validContent { | ||
| return MalformedRequestError{msg: fmt.Sprintf("digest is of incorrect size: %d", l)} | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Suggested change
| func validate(digest []byte, alg crypto.Hash) error { | |
| l := len(digest) | |
| var validContent bool | |
| switch alg { | |
| case crypto.SHA256: | |
| validContent = l == crypto.SHA256.Size() | |
| case crypto.SHA384: | |
| validContent = l == crypto.SHA384.Size() | |
| case crypto.SHA512: | |
| validContent = l == crypto.SHA512.Size() | |
| default: | |
| return MalformedRequestError{msg: fmt.Sprintf("unsupported hashing algorithm: %s", alg)} | |
| } | |
| if !validContent { | |
| return MalformedRequestError{msg: fmt.Sprintf("digest is of incorrect size: %d", l)} | |
| } | |
| return nil | |
| } | |
| func validate(digest []byte, alg crypto.Hash) error { | |
| switch alg { | |
| case crypto.SHA256, crypto.SHA384, crypto.SHA512: | |
| // no-op | |
| default: | |
| return MalformedRequestError{msg: fmt.Sprintf("unsupported hashing algorithm: %s", alg)} | |
| } | |
| if len(digest) != alg.Size() { | |
| return MalformedRequestError{msg: fmt.Sprintf("digest is of incorrect size: %d", l)} | |
| } | |
| return nil | |
| } |
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
gokarnm
approved these changes
Jun 29, 2022
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.